[PATCH] [libcxx] Partially address a FIXME in steady_clock::now()

Jon Roelofs jonathan at codesourcery.com
Fri Aug 29 09:49:47 PDT 2014


================
Comment at: include/chrono:943
@@ -941,1 +942,3 @@
 typedef steady_clock high_resolution_clock;
+#else
+typedef system_clock high_resolution_clock;
----------------
danalbert wrote:
> Should there be a warning that the system won't use steady_clock?
Implementing high_resolution_clock via a typedef to system_clock is explicitly allowed by the standard. I don't see a reason for a warning here.

================
Comment at: libcxx/test/utilities/time/time.clock/time.clock.steady/consistency.pass.cpp:14
@@ -13,2 +13,3 @@
 // XFAIL: with_system_lib=x86_64-apple-darwin12
+// XFAIL: no-monotonic-clock
 
----------------
danalbert wrote:
> I'd use UNSUPPORTED instead.
Ok

http://reviews.llvm.org/D4045






More information about the cfe-commits mailing list