r216669 - arm_acle: Fix error in ROR implementation

Dmitri Gribenko gribozavr at gmail.com
Fri Aug 29 06:34:31 PDT 2014


On Thu, Aug 28, 2014 at 4:25 PM, Yi Kong <Yi.Kong at arm.com> wrote:
> Author: kongyi
> Date: Thu Aug 28 10:25:52 2014
> New Revision: 216669
>
> URL: http://llvm.org/viewvc/llvm-project?rev=216669&view=rev
> Log:
> arm_acle: Fix error in ROR implementation
>
> The logic in calculating the rotate amount was flawed.

These intrinsics should have tests.  Yes, there are IR-checking tests
for some of them, but I think they are underconstrained in most cases.
What about actual execution tests in compiler-rt?

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the cfe-commits mailing list