[clang-tools-extra] r216718 - [clang-tidy] Don't suggest naming unnamed parameters on deleted/defaulted functions.

[Benjamin Kramer]

Author: d0k
Date: Fri Aug 29 03:58:35 2014
New Revision: 216718

URL: http://llvm.org/viewvc/llvm-project?rev=216718&view=rev
Log:
[clang-tidy] Don't suggest naming unnamed parameters on deleted/defaulted functions.

Modified:
    clang-tools-extra/trunk/clang-tidy/google/NamedParameterCheck.cpp
    clang-tools-extra/trunk/test/clang-tidy/google-readability-function.cpp

Modified: clang-tools-extra/trunk/clang-tidy/google/NamedParameterCheck.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/NamedParameterCheck.cpp?rev=216718&r1=216717&r2=216718&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/google/NamedParameterCheck.cpp (original)
+++ clang-tools-extra/trunk/clang-tidy/google/NamedParameterCheck.cpp Fri Aug 29 03:58:35 2014
@@ -40,7 +40,8 @@ void NamedParameterCheck::check(const Ma
   // Ignore declarations without a definition if we're not dealing with an
   // overriden method.
   const FunctionDecl *Definition = nullptr;
-  if (!Function->isDefined(Definition) &&
+  if ((!Function->isDefined(Definition) || Function->isDefaulted() ||
+       Function->isDeleted()) &&
       (!isa<CXXMethodDecl>(Function) ||
        cast<CXXMethodDecl>(Function)->size_overridden_methods() == 0))
     return;

Modified: clang-tools-extra/trunk/test/clang-tidy/google-readability-function.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/google-readability-function.cpp?rev=216718&r1=216717&r2=216718&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/google-readability-function.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/google-readability-function.cpp Fri Aug 29 03:58:35 2014
@@ -43,6 +43,9 @@ struct X {
 // CHECK-FIXES: X operator++(int /*unused*/) {}
   X operator--(int /*unused*/) {}
 
+  X(X&) = delete;
+  X &operator=(X&) = default;
+
   const int &i;
 };