[PATCH] Allow adding dll attributes on certain redecls with a warning if the decl hasn't been used yet (PR20746)

Hans Wennborg hans at chromium.org
Wed Aug 27 12:58:34 PDT 2014


Hi rnk,

This shouldn't really be allowed, but it comes up in real code (see PR20746), and as long as the decl hasn't been used there's no technical difficulty in supporting it, so we can just downgrade the error to a warning.

http://reviews.llvm.org/D5087

Files:
  include/clang/Basic/DiagnosticSemaKinds.td
  lib/Sema/SemaDecl.cpp
  test/Sema/dllexport.c
  test/Sema/dllimport.c
  test/SemaCXX/dllexport.cpp
  test/SemaCXX/dllimport.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5087.12996.patch
Type: text/x-patch
Size: 12521 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140827/8353f45d/attachment.bin>


More information about the cfe-commits mailing list