[libcxx] r216317 - Add return statement to a test class's assignment operator. Defect found by Coverity Scan.

Eric Fiselier eric at efcs.ca
Tue Aug 26 18:52:46 PDT 2014


That looks doable. I'll look into it. Thanks.
Can you point me to some documentation on `-verify`?

/Eric


On Tue, Aug 26, 2014 at 7:36 PM, Justin Bogner <mail at justinbogner.com>
wrote:

> Eric Fiselier <eric at efcs.ca> writes:
> > I'm not opposed to the change but using Filecheck really hurts our
> ability to
> > test standalone.
> > Also, we don't have that many compilation failures tests. I'm not sure
> how
> > badly this change is needed.
>
> Using clang -verify avoids that issue, but there's still the matter of
> having to update almost 300 tests to use it.
>
> Here's a quick example of hackily adding a verify flag instead of
> checking for rc 1 in the lit.cfg and updating the test under discussion:
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140826/939be1ea/attachment.html>


More information about the cfe-commits mailing list