[PATCH] Don't segfault in EmitCXXGlobalInitFunc when main file is a membuf

Nico Weber thakis at chromium.org
Tue Aug 26 11:24:05 PDT 2014


(I left a comment on this on phab a while ago, but I haven't received an
email for that yet. Not sure if phab's mailer is slow. The comment does
show up for me on the web interface.)


On Mon, Aug 25, 2014 at 12:32 PM, Keno Fischer <kfischer at college.harvard.edu
> wrote:

> Fixed minor nits, changed __GLOBAL_I_a to _GLOBAL__sub_I__null_ and added
> a test. I'd appreciate if somebody who uses CMake to run the unittests
> could test this. I tried to modify the CMakeLists by pattern matching, but
> haven't actually tested this.
>
> http://reviews.llvm.org/D5043
>
> Files:
>   lib/CodeGen/CGDeclCXX.cpp
>   unittests/CMakeLists.txt
>   unittests/CodeGen/BufferSourceTest.cpp
>   unittests/CodeGen/CMakeLists.txt
>   unittests/CodeGen/Makefile
>   unittests/Makefile
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140826/3e31cea7/attachment.html>


More information about the cfe-commits mailing list