[PATCH] [libcxx] Get categories.numeric and facet.numpunct localization tests passing on linux

Marshall Clow mclow.lists at gmail.com
Mon Aug 25 16:09:00 PDT 2014


Rewrote my #59 comment.

================
Comment at: test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:59
@@ -57,1 +58,3 @@
+        // http://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html
+#       if !defined(__GLIBC__)
             assert(np.thousands_sep() == ',');
----------------
My suggestion here is to change the #if from `!defined(__GLIBC__)` to `defined(_APPLE_)` and move on.

See if that breaks any other systems (FREEBSD, etc).

http://reviews.llvm.org/D4997






More information about the cfe-commits mailing list