[libcxx] r216317 - Add return statement to a test class's assignment operator. Defect found by Coverity Scan.

Eric Fiselier eric at efcs.ca
Sat Aug 23 19:14:07 PDT 2014


If we want to enable warnings and use static analysis tools these sort of
errors simply need to be fixed to prevent noise.

/Eric
 On Aug 23, 2014 7:06 PM, "Chandler Carruth" <chandlerc at google.com> wrote:

>
> On Sat, Aug 23, 2014 at 6:01 PM, Jonathan Roelofs <
> jonathan at codesourcery.com> wrote:
>
>> Wait a second, this test is *supposed* to be a compile failure, but not
>> for the reason I originally thought. It's testing that unique_ptr requires
>> the deleter have a public default constructor.  Because it fails to
>> compile, '-Wall -Wextra -pedantic -Werror' won't help us here :(
>>
>
> Hah.
>
> I don't think we should spend our time fixing warnings (coverity or
> otherwise) is code that is supposed to produce compile errors... seems a
> waste.
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140823/974eb13b/attachment.html>


More information about the cfe-commits mailing list