[libcxx] r216317 - Add return statement to a test class's assignment operator. Defect found by Coverity Scan.

Jonathan Roelofs jonathan at codesourcery.com
Sat Aug 23 16:40:18 PDT 2014


This is a fail test... could it be that the missing return is actually part of 
the behavior being checked by this test?


Cheers,

Jon

On 8/23/14, 12:36 AM, Eric Fiselier wrote:
> Author: ericwf
> Date: Sat Aug 23 01:36:11 2014
> New Revision: 216317
>
> URL: http://llvm.org/viewvc/llvm-project?rev=216317&view=rev
> Log:
> Add return statement to a test class's assignment operator. Defect found by Coverity Scan.
>
> Modified:
>      libcxx/trunk/test/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default01.fail.cpp
>
> Modified: libcxx/trunk/test/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default01.fail.cpp
> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default01.fail.cpp?rev=216317&r1=216316&r2=216317&view=diff
> ==============================================================================
> --- libcxx/trunk/test/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default01.fail.cpp (original)
> +++ libcxx/trunk/test/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default01.fail.cpp Sat Aug 23 01:36:11 2014
> @@ -25,7 +25,7 @@ class Deleter
>   public:
>
>       Deleter(Deleter&) {}
> -    Deleter& operator=(Deleter&) {}
> +    Deleter& operator=(Deleter&) { return *this; }
>
>       void operator()(void*) const {}
>   };
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded



More information about the cfe-commits mailing list