[PATCH] [ASan] Rename the ASan dynamic RT
Timur Iskhodzhanov
timurrrr at google.com
Fri Aug 22 07:51:23 PDT 2014
Hi samsonov, kcc,
While working on PR20214 [-MD CRT support on Windows] it turned out that we use the same base name for static and shared/dynamic runtimes.
This doesn't work well on Windows as creating ABC.DLL automatically creates an import library called ABC.LIB which makes CMake crazy.
http://reviews.llvm.org/D5026
Files:
cfe/trunk/lib/Driver/Tools.cpp
compiler-rt/trunk/lib/asan/CMakeLists.txt
Index: cfe/trunk/lib/Driver/Tools.cpp
===================================================================
--- cfe/trunk/lib/Driver/Tools.cpp
+++ cfe/trunk/lib/Driver/Tools.cpp
@@ -2200,7 +2200,7 @@
if (Shared) {
// Link dynamic runtime if necessary.
SmallString<128> LibSanitizer =
- getSanitizerRTLibName(TC, "asan", Shared);
+ getSanitizerRTLibName(TC, "asan_dynamic", Shared);
CmdArgs.insert(CmdArgs.begin(), Args.MakeArgString(LibSanitizer));
}
Index: compiler-rt/trunk/lib/asan/CMakeLists.txt
===================================================================
--- compiler-rt/trunk/lib/asan/CMakeLists.txt
+++ compiler-rt/trunk/lib/asan/CMakeLists.txt
@@ -162,7 +162,7 @@
add_dependencies(asan clang_rt.asan-preinit-${arch})
add_compiler_rt_runtime(clang_rt.asan-dynamic-${arch} ${arch} SHARED
- OUTPUT_NAME clang_rt.asan-${arch}
+ OUTPUT_NAME clang_rt.asan_dynamic-${arch}
SOURCES $<TARGET_OBJECTS:RTAsan_dynamic.${arch}>
${ASAN_COMMON_RUNTIME_OBJECTS}
CFLAGS ${ASAN_DYNAMIC_CFLAGS}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5026.12842.patch
Type: text/x-patch
Size: 1092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140822/b7b4c50c/attachment.bin>
More information about the cfe-commits
mailing list