[PATCH] [libcxx] Add support for LLVM_USE_SANITIZER to libcxx when being built standalone and in-tree

Dan Albert danalbert at google.com
Sun Aug 17 21:30:30 PDT 2014


================
Comment at: CMakeLists.txt:30
@@ -29,3 +29,3 @@
 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
-  set(LIBCXX_BUILT_STANDALONE 1)
+  set(LIBCXX_BUILT_STANDALONE 1 CACHE BOOL "Libcxx is being built standalone")
 endif()
----------------
What is this change for? Doesn't this just list the variable in the cmake GUI? We don't want this to be configurable.

================
Comment at: test/lit.cfg:318
@@ +317,3 @@
+built_w_san = getattr(config, 'llvm_use_sanitizer')
+if built_w_san is not None and built_w_san.strip():
+    built_w_san = built_w_san.strip()
----------------
"is not None" is unnecessary.

http://reviews.llvm.org/D4949






More information about the cfe-commits mailing list