[PATCH] Teach Clang how to use response files when calling other tools

Rafael Auler rafaelauler at gmail.com
Fri Aug 15 20:05:28 PDT 2014


In this new patch, I now use writeFileWithEncoding by passing an enum member (conforming to my new patch in D4896). I also updated my changes in Tool, separating ResponseFileSupport in  ResponseFileSupport, which will only tell whether the tool has full support for response files, file lists or no support, and ResponseFileEncoding, which will tell which encoding we should use when writing this response file. 

I believe this makes the whole encoding issue much more clear and explicit. I also adopted Rafael's suggestion and added a comment explictly stating which tools need to use the current code page in their response file encoding.

http://reviews.llvm.org/D4897

Files:
  include/clang/Driver/Compilation.h
  include/clang/Driver/Job.h
  include/clang/Driver/Tool.h
  lib/Driver/Compilation.cpp
  lib/Driver/Job.cpp
  lib/Driver/Tools.cpp
  lib/Driver/Tools.h
  test/Driver/response-file.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4897.12580.patch
Type: text/x-patch
Size: 38708 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140816/ab100023/attachment.bin>


More information about the cfe-commits mailing list