[PATCH] OpenCL: blocks crash Clang when using multiple address spaces

Anastasia Stulova Anastasia.Stulova at arm.com
Wed Aug 13 08:59:17 PDT 2014


Looks good to me. Although, I was just wondering if adding extra constCstr variable could be avoided? It seems to be fine to just use i8p everywhere.

Anastasia

-----Original Message-----
From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Pekka Jääskeläinen
Sent: 13 August 2014 12:59
To: llvm cfe
Subject: Re: [PATCH] OpenCL: blocks crash Clang when using multiple address spaces

Ping?

It would be nice to get this in to 3.5 to avoid a pocl regression.

Perhaps this was too trivial for a review, but I thought to be extra careful as I haven't worked on Clang so much.

On 08/07/2014 12:04 PM, Pekka Jääskeläinen wrote:
> Hi,
>
> This patch fixes a crash when compiling blocks in OpenCL with multiple
> address spaces.
>
> OK to commit this to both trunk and the 3.5 branch?

--
Pekka

_______________________________________________
cfe-commits mailing list
cfe-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2548782





More information about the cfe-commits mailing list