[PATCH] Fix the \param comments to have the parameter name.

Samuel Benzaquen sbenza at google.com
Tue Aug 12 14:59:20 PDT 2014


Closed by commit rL215476 (authored by @sbenza).

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D4875

Files:
  cfe/trunk/include/clang/ASTMatchers/Dynamic/Parser.h
  cfe/trunk/include/clang/ASTMatchers/Dynamic/Registry.h
  cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h

Index: cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h
===================================================================
--- cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h
+++ cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h
@@ -56,7 +56,8 @@
   ///
   /// \param To the requested destination type.
   ///
-  /// \param Value corresponding to the "specificity" of the convertion.
+  /// \param Specificity value corresponding to the "specificity" of the
+  ///   convertion.
   bool isConvertibleTo(ArgKind To, unsigned *Specificity) const;
 
   bool operator<(const ArgKind &Other) const {
@@ -166,7 +167,8 @@
   ///
   /// \param Kind the requested destination type.
   ///
-  /// \param Value corresponding to the "specificity" of the convertion.
+  /// \param Specificity value corresponding to the "specificity" of the
+  ///   convertion.
   bool isConvertibleTo(ast_type_traits::ASTNodeKind Kind,
                        unsigned *Specificity) const {
     if (Value)
@@ -290,16 +292,18 @@
   ///
   /// \param Kind the requested destination type.
   ///
-  /// \param Value corresponding to the "specificity" of the convertion.
+  /// \param Specificity value corresponding to the "specificity" of the
+  ///   convertion.
   bool isConvertibleTo(ArgKind Kind, unsigned* Specificity) const;
 
   /// \brief Determines if the contained value can be converted to any kind
   /// in \p Kinds.
   ///
   /// \param Kinds the requested destination types.
   ///
-  /// \param Value corresponding to the "specificity" of the convertion. It is
-  /// the maximum specificity of all the possible conversions.
+  /// \param Specificity value corresponding to the "specificity" of the
+  ///   convertion. It is the maximum specificity of all the possible
+  ///   conversions.
   bool isConvertibleTo(ArrayRef<ArgKind> Kinds, unsigned *Specificity) const;
 
   /// \brief String representation of the type of the value.
Index: cfe/trunk/include/clang/ASTMatchers/Dynamic/Registry.h
===================================================================
--- cfe/trunk/include/clang/ASTMatchers/Dynamic/Registry.h
+++ cfe/trunk/include/clang/ASTMatchers/Dynamic/Registry.h
@@ -81,7 +81,7 @@
   /// \brief Compute the list of completions that match any of
   /// \p AcceptedTypes.
   ///
-  /// \param All types accepted for this completion.
+  /// \param AcceptedTypes All types accepted for this completion.
   ///
   /// \return All completions for the specified types.
   /// Completions should be valid when used in \c lookupMatcherCtor().
Index: cfe/trunk/include/clang/ASTMatchers/Dynamic/Parser.h
===================================================================
--- cfe/trunk/include/clang/ASTMatchers/Dynamic/Parser.h
+++ cfe/trunk/include/clang/ASTMatchers/Dynamic/Parser.h
@@ -109,7 +109,7 @@
     /// \brief Compute the list of completions that match any of
     /// \p AcceptedTypes.
     ///
-    /// \param All types accepted for this completion.
+    /// \param AcceptedTypes All types accepted for this completion.
     ///
     /// \return All completions for the specified types.
     /// Completions should be valid when used in \c lookupMatcherCtor().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4875.12421.patch
Type: text/x-patch
Size: 3204 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140812/fdca11d3/attachment.bin>


More information about the cfe-commits mailing list