r215291 - NetBSD/aarch64 has no libgcc or libstdc++. Drop arm64 tests.

Chandler Carruth chandlerc at google.com
Sun Aug 10 16:19:43 PDT 2014


On Sat, Aug 9, 2014 at 11:28 AM, Joerg Sonnenberger <joerg at bec.de> wrote:

> NetBSD/aarch64 has no libgcc or libstdc++. Drop arm64 tests.
>

OK...


>
> Modified:
>     cfe/trunk/lib/Driver/ToolChains.cpp
>     cfe/trunk/lib/Driver/Tools.cpp
>     cfe/trunk/test/Driver/netbsd.c
>     cfe/trunk/test/Driver/netbsd.cpp
>
> Modified: cfe/trunk/lib/Driver/ToolChains.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=215291&r1=215290&r2=215291&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)
> +++ cfe/trunk/lib/Driver/ToolChains.cpp Sat Aug  9 13:28:36 2014
> @@ -2643,6 +2643,7 @@ NetBSD::GetCXXStdlibType(const ArgList &
>    getTriple().getOSVersion(Major, Minor, Micro);
>    if (Major >= 7 || (Major == 6 && Minor == 99 && Micro >= 49) || Major
> == 0) {
>      switch (getArch()) {
> +    case llvm::Triple::aarch64:
>

But you also added cases to these switches? If this is actually just to
drop the tests below, it'd be nice to explain why in the commit log. As-is,
these look like unintentional commits or untested changes?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140810/d8601290/attachment.html>


More information about the cfe-commits mailing list