[PATCH] Add missing mingw-w64 case for Triple -> TargetInfo mapping

Keno Fischer kfischer at college.harvard.edu
Thu Aug 7 22:08:18 PDT 2014


I was setting the clang triple to the result of
llvm::sys::getProcessTriple(), without calling normalize on it. Until
the enumeration is removed I think it would be nice to have a better
error rather than just silently failing.

On Fri, Aug 8, 2014 at 1:05 AM, Saleem Abdulrasool
<compnerd at compnerd.org> wrote:
> MinGW is no longer treated as an OS.  During the 3.5 cycle, we normalized the Windows triples.  MinGW is treated as an environment, the OS is Windows.  The resultant triple would be i686-windows-gnu or x86_64-windows-gnu.  Users are still able to pass the old triple, however, internally, we expect the normalized form now.
>
> The cases you are adding here were intentionally removed during that change.  Please do not add these back.  In fact, we should remove MinGW from the OS enumeration.
>
> What exactly are you trying to do that this is causing you an issue?
>
> http://reviews.llvm.org/D4804
>
>




More information about the cfe-commits mailing list