[PATCH] Clang Rename Tool

[Manuel Klimek]

On Thu, Aug 7, 2014 at 7:47 PM, Matthew Plant <mplant at google.com> wrote:

> I'll get rid of the operator renaming code and take a look at unit tests.
>
> ================
> Comment at: clang-rename/ClangRename.cpp:69-70
> @@ +68,4 @@
> +newFrontendActionFactory(ActionT *Action) {
> +  // Renaming CreateASTConsumer to createASTConsumer doesn't work, so we
> have to
> +  // create our own custom factory.
> +  struct SimpleFactory : public tooling::FrontendActionFactory {
> ----------------
> Manuel Klimek wrote:
> > Can you explain what exactly didn't work? Perhaps give me the compile
> error? But it's no biggie - I can also get rid of this once it's checked in
> - the template error messages are sometimes hard to get through :)
> It spat out a virtual method not implemented error. I've grepped through
> the code, and I couldn't find one interface with a virtual method
> createASTConsumer. Did you mean some method with a different name?
>

Nope, I meant the newFrontendActionFactory function from Tooling.h that is
templated to take anything that has a newASTConsumer method. Ah, I think
it's new vs. create here, sorry for the typo...



>
> http://reviews.llvm.org/D4739
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140807/87414005/attachment.html>