Patch to force SuitableAlign's alignment when loading on object with larger alignment

jahanian fjahanian at apple.com
Tue Aug 5 09:02:29 PDT 2014


Thanks John. One comment bellow.

On Aug 4, 2014, at 5:39 PM, John McCall <rjmccall at apple.com> wrote:

> 
> +  ASTContext &Context = CGM.getContext();
> +  if (const UnaryOperator *UOPE = dyn_cast<UnaryOperator>(E))
> +    if (UOPE->getOpcode() == UO_Deref) {
> 
> This is far too specific.  In your first patch, you were modifying
> MakeNaturalAlignAddrLValue, which I think was fine; why did you
> change your mind?

Because of this earlier comment of yours:

"We can’t change the ABI alignment; that would change struct layout.”

I thought from comment that it is not the right place for this code, as it impacts
ABI change. I will try again.

- Fariborz



> 
> John.





More information about the cfe-commits mailing list