r214298 - Suppress clang/test/Sema/struct-packed-align.c for targeting LLP64.

[Aaron Ballman]

The closest solution I could come up with was what I've attached. Does
that look reasonable to you?

~Aaron

On Fri, Aug 1, 2014 at 8:34 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> On Fri, Aug 1, 2014 at 8:33 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>> LLP64 is uncertain. I guess ms-compatibilities.
>> Could you fix it?
>
> I can try on Monday if you don't get to it sooner. Thanks!
>
> ~Aaron
>
>>
>> 2014/08/02 9:25 "Aaron Ballman" <aaron at aaronballman.com>:
>>
>>> On Wed, Jul 30, 2014 at 8:33 AM, Aaron Ballman <aaron at aaronballman.com>
>>> wrote:
>>> > On Wed, Jul 30, 2014 at 6:44 AM, NAKAMURA Takumi <geek4civic at gmail.com>
>>> > wrote:
>>> >> Author: chapuni
>>> >> Date: Wed Jul 30 05:44:35 2014
>>> >> New Revision: 214298
>>> >>
>>> >> URL: http://llvm.org/viewvc/llvm-project?rev=214298&view=rev
>>> >> Log:
>>> >> Suppress clang/test/Sema/struct-packed-align.c for targeting LLP64.
>>> >>
>>> >> Modified:
>>> >>     cfe/trunk/test/Sema/struct-packed-align.c
>>> >>
>>> >> Modified: cfe/trunk/test/Sema/struct-packed-align.c
>>> >> URL:
>>> >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/struct-packed-align.c?rev=214298&r1=214297&r2=214298&view=diff
>>> >>
>>> >> ==============================================================================
>>> >> --- cfe/trunk/test/Sema/struct-packed-align.c (original)
>>> >> +++ cfe/trunk/test/Sema/struct-packed-align.c Wed Jul 30 05:44:35 2014
>>> >> @@ -120,6 +120,7 @@ extern int m1[sizeof(struct packed_fas2)
>>> >>  extern int m2[__alignof(struct packed_fas2) == 1 ? 1 : -1];
>>> >>
>>> >>  // Attribute aligned can round down typedefs.  PR9253
>>> >> +// REQUIRES: LP64
>>> >>  typedef long long  __attribute__((aligned(1))) nt;
>>> >
>>> > Why does this test require LP64? The type here is long long, which is
>>> > 64-bits everywhere, and the only other type involved in the struct is
>>> > a char.
>>> >
>>> > Also, the commit log says LLP64 and the comment says LP64...
>>>
>>> Ping.
>>>
>>> ~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: struct-packed-align.c.patch
Type: application/octet-stream
Size: 936 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140804/f1a795c0/attachment.obj>