[PATCH] Improved source range in nonnull diagnostics

jahanian fjahanian at apple.com
Thu Jul 31 14:05:26 PDT 2014


On Jul 31, 2014, at 12:21 PM, Aaron Ballman <aaron at aaronballman.com> wrote:

> The attach patch addresses a FIXME asking for improved source range
> information when a nonnull parameter or return type is not a pointer
> type. A few questions come to mind:
> 
> 1) Is my addition to ObjCMethodDecl the correct way to get return type
> source range information?

LGTM. We use the same in other places.For example, in Sema::CheckObjCMethodOverride
- Fariborz

> 2) Does this patch require tests? If so, do we have any source range
> tests I should model after?
> 
> Thanks!
> 
> ~Aaron
> <nonnull.patch>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140731/a99463ff/attachment.html>


More information about the cfe-commits mailing list