[PATCH] Fix crash when assiging to a property with an invalid type

jahanian fjahanian at apple.com
Wed Jul 30 13:43:42 PDT 2014


On Jul 30, 2014, at 1:21 PM, Olivier Goffart <ogoffart at kde.org> wrote:

> It does crash for me (linux, r214316).
> In debug mode, there is an assert. In release mode it segfaults.

Strange, I tested it against a debuggable compiler (with assert on). 
Let me investigate a bit more why it doesn’t crash for me.

- Fariborz

> 
> -- 
> Olivier
> 
> On Wednesday 30 July 2014 09:14:09 jahanian wrote:
>> I don’t see a crash with TOT clang:
>> 
>> t.m:3:3: error: unknown type name 'A'
>>  A* response; // expected-error {{unknown type name 'A'}}
>>  ^
>> t.m:8:11: error: unknown type name 'A'
>> @property A* response;  // expected-error {{unknown type name 'A'}}
>>          ^
>> t.m:13:16: error: expected a type
>> - (void) foo :(A*) a   // expected-error {{expected a type}}
>>               ^
>> t.m:15:17: error: assignment to readonly property
>>  self.response = a;
>>  ~~~~~~~~~~~~~ ^ ~
>> 4 errors generated.
>> 
>> - Fariborz
>> 
>> On Jul 30, 2014, at 12:42 AM, Olivier Goffart <ogoffart at kde.org> wrote:
>>> Hi,
>>> 
>>> Attached you will find a fix for a crash I have when parsing objective C
>>> with missing include.
>>> This is a regression against clang 3.4 which did not crash.
>>> 
>>> My approach here is naive and just fixes the symptoms (the crash).
>>> 
>>> Regards
> 





More information about the cfe-commits mailing list