[PATCH] OpenCL/SPIR - kernel_arg_base_type metadata node

Pekka Jääskeläinen pekka.jaaskelainen at tut.fi
Tue Jul 29 10:51:15 PDT 2014


Hi Fraser,

On 07/28/2014 07:36 PM, Fraser Cormack wrote:
> +      // Turn "unsigned type" to "utype"
> +      pos = baseTypeName.find("unsigned");
> +      if (pos != std::string::npos)
> +        baseTypeName.erase(pos+1, 8);

Can you add a test case that exercises this branch?

Otherwise, LGTM.

-- 
--Pekka




More information about the cfe-commits mailing list