[PATCH][TEST] Improve tests for #pragma clang optimize off/on

Dario Domizioli dario.domizioli at gmail.com
Mon Jul 28 07:43:42 PDT 2014


Thanks for the review!
I have committed revision 214086.

I had thought about committing anyway and having a post-commit review, but
I still don't have a long track record so I thought it was safer to ask for
a pre-commit review.

Cheers,
    Dario Domizioli
    SN Systems - Sony Computer Entertainment Group





On 28 July 2014 15:22, Aaron Ballman <aaron at aaronballman.com> wrote:

> On Mon, Jul 28, 2014 at 10:16 AM, Dario Domizioli
> <dario.domizioli at gmail.com> wrote:
> >
> > Ping. :-)
> >
> > It's just a test improvement patch so it shouldn't be controversial.
>
> LGTM!
>
> Btw, improved test coverage is something that can usually be dealt
> with post-commit, especially when it's functionality you've been
> involved with before.
>
> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140728/0743362c/attachment.html>


More information about the cfe-commits mailing list