r213105 - Use the integrated assembler by default on OpenBSD/sparc.

[Brad Smith]

On 22/07/14 3:15 PM, Rafael Espíndola wrote:
> Why is this OpenBSD specific? Could it be moved to Generic_GCC?

None of the *BSD's should have these bits, they should be in
Generic_GCC.

> On 15 July 2014 19:07, Brad Smith <brad at comstyle.com> wrote:
>> Author: brad
>> Date: Tue Jul 15 18:07:10 2014
>> New Revision: 213105
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=213105&view=rev
>> Log:
>> Use the integrated assembler by default on OpenBSD/sparc.
>>
>> Modified:
>>      cfe/trunk/lib/Driver/ToolChains.h
>>      cfe/trunk/test/Driver/openbsd.c
>>
>> Modified: cfe/trunk/lib/Driver/ToolChains.h
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.h?rev=213105&r1=213104&r2=213105&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Driver/ToolChains.h (original)
>> +++ cfe/trunk/lib/Driver/ToolChains.h Tue Jul 15 18:07:10 2014
>> @@ -538,7 +538,9 @@ public:
>>     }
>>
>>     virtual bool IsIntegratedAssemblerDefault() const {
>> -    if (getTriple().getArch() == llvm::Triple::ppc)
>> +    if (getTriple().getArch() == llvm::Triple::ppc ||
>> +        getTriple().getArch() == llvm::Triple::sparc ||
>> +        getTriple().getArch() == llvm::Triple::sparcv9)
>>         return true;
>>       return Generic_ELF::IsIntegratedAssemblerDefault();
>>     }
>>
>> Modified: cfe/trunk/test/Driver/openbsd.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/openbsd.c?rev=213105&r1=213104&r2=213105&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Driver/openbsd.c (original)
>> +++ cfe/trunk/test/Driver/openbsd.c Tue Jul 15 18:07:10 2014
>> @@ -60,7 +60,11 @@
>>   // CHECK-MIPS64EL: as{{.*}}" "-mabi" "64" "-EL"
>>   // CHECK-MIPS64EL-PIC: as{{.*}}" "-mabi" "64" "-EL" "-KPIC"
>>
>> -// Check that the integrated assembler is enabled for PowerPC
>> +// Check that the integrated assembler is enabled for PowerPC and SPARC
>>   // RUN: %clang -target powerpc-unknown-openbsd -### -c %s 2>&1 \
>> -// RUN:   | FileCheck -check-prefix=CHECK-POWERPC-AS %s
>> -// CHECK-POWERPC-AS-NOT: "-no-integrated-as"
>> +// RUN:   | FileCheck -check-prefix=CHECK-IAS %s
>> +// RUN: %clang -target sparc-unknown-openbsd -### -c %s 2>&1 \
>> +// RUN:   | FileCheck -check-prefix=CHECK-IAS %s
>> +// RUN: %clang -target sparc64-unknown-openbsd -### -c %s 2>&1 \
>> +// RUN:   | FileCheck -check-prefix=CHECK-IAS %s
>> +// CHECK-IAS-NOT: "-no-integrated-as"
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.