[PATCH] Do not define the gcc style target specific pre-defined preprocessor macros in clang-cl

Reid Kleckner rnk at google.com
Mon Jul 21 18:09:37 PDT 2014


We don't need it, right?  Dropping it seems fine to me.  If more people
report that they expected __x86_64__ et al to imply __GNUC__ then I'm happy
to reconsider.


On Mon, Jul 21, 2014 at 3:26 PM, Ehsan Akhgari <ehsan.akhgari at gmail.com>
wrote:

> So with the -arch and -m flags added to clang-cl, the backend should be
> able to handle all of these intrinsics properly now.
>
> How would you like me to proceed with this patch?
>
> Thanks!
>
> --
> Ehsan
> <http://ehsanakhgari.org/>
>
>
> On Thu, Jul 10, 2014 at 2:30 PM, Ehsan Akhgari <ehsan.akhgari at gmail.com>
> wrote:
>
>> In our code base I think it's only occurrence of this problem, but I do
>> expect this to be the sort of thing that breaks more than just libyuv in
>> the wild.  That being said, I'll leave it up to you whether we should take
>> this or not, and will address the comment below when landing if we decide
>> to to do so.
>>
>> Cheers,
>>
>> --
>> Ehsan
>> <http://ehsanakhgari.org/>
>>
>> http://reviews.llvm.org/D4415
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140721/28a9e3d6/attachment.html>


More information about the cfe-commits mailing list