[PATCH] Add support for unroll pragma

Mark Heffernan meheff at google.com
Mon Jul 21 11:17:51 PDT 2014


Thanks for the review.  Committed as r213574.

On Mon, Jul 21, 2014 at 8:37 AM, Aaron Ballman <aaron.ballman at gmail.com>
wrote:

> > +      std::string DiagnosticName = "#pragma unroll";
> > +      return DiagnosticName + getValueString();
>
> No need for the std::string declaration.
>

Done.


> > +    } else {
> > +      assert(SpellingIndex == Pragma_clang_loop && "Unexpected
> spelling");
> > +      std::string DiagnosticName = getOptionName(option);
> > +      return DiagnosticName + getValueString();
>
> Same here.
>

Done.  Wrapped getOptionName in std::string to make operator+ work.

Mark

> +    }
>
> LGTM!
>
> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140721/6dd8994a/attachment.html>


More information about the cfe-commits mailing list