[PATCH] CodeGen: Properly null-check typeid expressions

Richard Smith richard at metafoo.co.uk
Fri Jul 18 13:53:04 PDT 2014


LGTM

================
Comment at: test/CodeGenCXX/typeid-should-throw.cpp:62-64
@@ +61,5 @@
+
+void f11(A *x) {
+  A t;
+  A &r = t;
+  typeid(*x ?: r);
----------------
You could make `t` and `r` parameters to match the style of other tests.

http://reviews.llvm.org/D4592






More information about the cfe-commits mailing list