[PATCH] __assume side-effects warning

[Richard Smith]

One comment; otherwise, LGTM

================
Comment at: lib/Sema/SemaChecking.cpp:1954
@@ +1953,3 @@
+  Expr *Arg = TheCall->getArg(0);
+  if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
+
----------------
This is neither necessary nor sufficient; the relevant thing here is `Arg->isInstantiationDependent()`.

http://reviews.llvm.org/D4552