r213171 - Make clang's rewrite engine a core feature

[Richard Smith]

On Wed, Jul 16, 2014 at 9:48 AM, Alp Toker <alp at nuanti.com> wrote:

> Author: alp
> Date: Wed Jul 16 11:48:33 2014
> New Revision: 213171
>
> URL: http://llvm.org/viewvc/llvm-project?rev=213171&view=rev
> Log:
> Make clang's rewrite engine a core feature
>
> The rewrite facility's footprint is small so it's not worth going to these
> lengths to support disabling at configure time, particularly since key
> compiler
> features now depend on it.
>
> Meanwhile the Objective-C rewriters have been moved under the
> ENABLE_CLANG_ARCMT umbrella for now as they're comparatively heavy and
> still
> potentially worth excluding from lightweight builds.
>
> Tests are now passing with any combination of feature flags. The flags
> historically haven't been tested by LLVM's build servers so caveat emptor.


Hi Alp,

A reorganization of this magnitude should be discussed before being
committed. More generally, changes to the file organization should
generally get the nod of approval from the relevant code owner. (That said,
I think this reorg is an improvement, so I'm not objecting to the change,
just to the process.)

It also would have been courteous to ask if anyone was using the
CLANG_ENABLE_REWRITER
flag before removing it. See r170135, which gives a justification for
including this flag, which doesn't seem to have gone away.

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140716/ad83990d/attachment.html>