[PATCH] Don't set ObjCAutoRefCount in original CI
jahanian
fjahanian at apple.com
Tue Jul 15 10:34:25 PDT 2014
Looks like Argyrios is intentionally setting it to impact arc related diagnostics. He owns ARCMT.cpp.
- Fariborz
On Jul 15, 2014, at 10:28 AM, Alp Toker <alp at nuanti.com> wrote:
> Ping
>
> On 07/07/2014 01:35, Alp Toker wrote:
>> Hi Fariborz,
>>
>> As far as I can tell the original CI is immutable at this point, so changing it isn't needed or desirable at this point. OK to remove this line? No change in test results.
>>
>> Alp.
>>
>> --
>> http://www.nuanti.com
>> the browser experts
>>
>>
>> ObjCAutoRefCount.patch
>>
>>
>> diff --git a/lib/ARCMigrate/ARCMT.cpp b/lib/ARCMigrate/ARCMT.cpp
>> index 8a13b2e..9d525ff 100644
>> --- a/lib/ARCMigrate/ARCMT.cpp
>> +++ b/lib/ARCMigrate/ARCMT.cpp
>> @@ -369,7 +369,6 @@ static bool applyTransforms(CompilerInvocation &origCI,
>> DiagClient, /*ShouldOwnClient=*/false));
>> if (outputDir.empty()) {
>> - origCI.getLangOpts()->ObjCAutoRefCount = true;
>> return migration.getRemapper().overwriteOriginal(*Diags);
>> } else {
>> return migration.getRemapper().flushToDisk(outputDir, *Diags);
>
> --
> http://www.nuanti.com
> the browser experts
>
More information about the cfe-commits
mailing list