r212909 - Add test cases for AArch64 hints codegen

Saleem Abdulrasool compnerd at compnerd.org
Sun Jul 13 16:52:05 PDT 2014


On Sun, Jul 13, 2014 at 9:17 AM, Yi Kong <Yi.Kong at arm.com> wrote:

> Author: kongyi
> Date: Sun Jul 13 11:17:30 2014
> New Revision: 212909
>
> URL: http://llvm.org/viewvc/llvm-project?rev=212909&view=rev
> Log:
> Add test cases for AArch64 hints codegen
>
> Modified:
>     cfe/trunk/test/CodeGen/builtins-arm64.c
>
> Modified: cfe/trunk/test/CodeGen/builtins-arm64.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtins-arm64.c?rev=212909&r1=212908&r2=212909&view=diff
>
> ==============================================================================
> --- cfe/trunk/test/CodeGen/builtins-arm64.c (original)
> +++ cfe/trunk/test/CodeGen/builtins-arm64.c Sun Jul 13 11:17:30 2014
> @@ -14,3 +14,11 @@ unsigned rbit(unsigned a) {
>  unsigned long long rbit64(unsigned long long a) {
>    return __builtin_arm_rbit64(a);
>  }
> +
> +void hints() {
> +  __builtin_arm_yield();  //CHECK: call {{.*}} @llvm.aarch64.hint(i32 1)
> +  __builtin_arm_wfe();    //CHECK: call {{.*}} @llvm.aarch64.hint(i32 2)
> +  __builtin_arm_wfi();    //CHECK: call {{.*}} @llvm.aarch64.hint(i32 3)
> +  __builtin_arm_sev();    //CHECK: call {{.*}} @llvm.aarch64.hint(i32 4)
> +  __builtin_arm_sevl();   //CHECK: call {{.*}} @llvm.aarch64.hint(i32 5)
> +}
>

I am a bit confused by this change.  What does SVN r212890 miss in terms of
testing?  test/CodeGen/arm_acle.c already covers all of these, doesn't it?


>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140713/8cfcb1a1/attachment.html>


More information about the cfe-commits mailing list