Fix __UINTPTR_TYPE__ definition after r211657

Richard Smith richard at metafoo.co.uk
Sun Jul 13 16:42:13 PDT 2014


On Sun, Jul 13, 2014 at 3:10 PM, Joerg Sonnenberger <joerg at britannica.bec.de
> wrote:

> Hi all,
> the attached patch ensures that __INTPTR_TYPE__ and __UINTPTR_TYPE__ are
> consistent as the existing logic would pick e.g. long and unsigned int
> on ARM. One issue I found during this is that the NVPTX backend is
> using unsigned types here, which doesn't make sense to me.
>

The change to SemaOverload.cpp looks unrelated? Other than that, this LGTM,
although I'm a little concerned that it might be intptr_t we were getting
wrong on some of those targets rather than uintptr_t. Have you checked that
this gives the same results as GCC?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140713/0595ede0/attachment.html>


More information about the cfe-commits mailing list