[PATCH] Add nonnull in CodeGen for __attribute__((nonnull))

[Hal Finkel]

----- Original Message -----
> From: "Hal Finkel" <hfinkel at anl.gov>
> To: "Aaron Ballman" <aaron.ballman at gmail.com>
> Cc: reviews+D4472+public+47c3563e7d77bf55 at reviews.llvm.org, "Richard Smith" <richard at metafoo.co.uk>, "llvm cfe"
> <cfe-commits at cs.uiuc.edu>
> Sent: Friday, July 11, 2014 12:13:19 PM
> Subject: Re: [PATCH] Add nonnull in CodeGen for __attribute__((nonnull))
> 
> ----- Original Message -----
> > From: "Aaron Ballman" <aaron.ballman at gmail.com>
> > To: reviews+D4472+public+47c3563e7d77bf55 at reviews.llvm.org
> > Cc: "Hal Finkel" <hfinkel at anl.gov>, "Richard Smith"
> > <richard at metafoo.co.uk>, "Nick Lewycky" <nlewycky at google.com>,
> > "llvm cfe" <cfe-commits at cs.uiuc.edu>
> > Sent: Friday, July 11, 2014 11:23:26 AM
> > Subject: Re: [PATCH] Add nonnull in CodeGen for
> > __attribute__((nonnull))
> > 
> > On Fri, Jul 11, 2014 at 10:13 AM, hfinkel at anl.gov <hfinkel at anl.gov>
> > wrote:
> > > Hi rsmith, nlewycky, aaron.ballman,
> > >
> > > We now have an LLVM-level nonnull attribute that can be applied
> > > to
> > > function parameters, and we emit it for reference types (as of
> > > r209723), but we don't yet emit it when a
> > > __attribute__((nonnull))
> > > is provided. This patch adds support for turning
> > >     __attribute__((nonnull))  on the source level into nonnull at
> > > the IR level.
> > 
> > LGTM!
> 
> Thanks. Interestingly, your fix in r212827 may have broken this. I'm
> investigating, but if you have any thoughts please let me know.

Never mind; I had a branch-switching error ;)

 -Hal

> 
>  -Hal
> 
> > 
> > ~Aaron
> > 
> 
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory