[PATCH] MSVC compat: Allow lookup of friend types in enclosing namespaces
Richard Smith
richard at metafoo.co.uk
Thu Jul 10 15:35:06 PDT 2014
LGTM
================
Comment at: lib/Sema/SemaDecl.cpp:10740
@@ +10739,3 @@
+ // This tag should be declared in a namespace, which can only be enclosed by
+ // other namespaces. Bail if something there's an anonymous namespace in
+ // the chain.
----------------
Stray 'something'?
================
Comment at: lib/Sema/SemaDecl.cpp:10986
@@ +10985,3 @@
+ NamedDecl *ND = Previous.getFoundDecl();
+ Sema::SemaDiagnosticBuilder D =
+ Diag(NameLoc, diag::ext_friend_tag_redecl_outside_namespace);
----------------
`auto`?
http://reviews.llvm.org/D4443
More information about the cfe-commits
mailing list