[PATCH] [libcxxabi] Add support for building and testing the unwinder.

Jonathan Roelofs jonathan at codesourcery.com
Thu Jul 10 10:44:38 PDT 2014


Well, phabricator didn't quite do what I intended with that....

On 7/10/14, 11:41 AM, Jon Roelofs wrote:

Here I was intending to quote danalbert's reply:

 > Because there is no support for it. It isn't actually my code that prevents 
it from building, but rather the check at src/Unwind/UnwindCursor.hpp:1278 which 
requires either _LIBUNWIND_SUPPORT_COMPACT_UNWIND, 
_LIBUNWIND_SUPPORT_DWARF_UNWIND, or LIBCXXABI_AM_EHABI. The config that was 
added with the EHABI change left the dwarf and compact defines set to 0 because 
neither is available yet (for Linux). I'm working on fixing this right now, but 
it will be a different patch.


> Ah ok. Now I remember you mentioning this on #llvm.
>
> ================
> Comment at: src/Unwind/CMakeLists.txt:15
> @@ +14,3 @@
> +
> +set_source_files_properties(${LIBUNWIND_ASM_SOURCES} PROPERTIES LANGUAGE C)
> +
> ----------------
> Dan Albert wrote:
>> Jon Roelofs wrote:
>>> I'm very 'green' when it comes to cmake, but this looks odd. Should the language be set to some ASM thing instead of C?
>> I had done that originally, but it didn't work when building in tree. I'm also pretty new to cmake, but I looked at compiler-rt and this is how they handle it.
> ok
>
> http://reviews.llvm.org/D4448
>
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded



More information about the cfe-commits mailing list