r212666 - [Driver] Expose getARMCPUForMArch() function in the Driver API; NFC.

[Eric Christopher]

Seems like an odd API to expose out of the driver. Perhaps move it to
Triple and do something there? Other API choices? Also unless there's
a test on it then someone might end up just re-inlining it where
you've got it separated :)

-eric

On Wed, Jul 9, 2014 at 10:05 PM, Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:
> It is useful out-of-tree.
>
> On Jul 9, 2014, at 6:26 PM, Eric Christopher <echristo at gmail.com> wrote:
>
>> Why?
>>
>> -eric
>>
>> On Wed, Jul 9, 2014 at 6:03 PM, Argyrios Kyrtzidis <akyrtzi at gmail.com> wrote:
>>> Author: akirtzidis
>>> Date: Wed Jul  9 20:03:37 2014
>>> New Revision: 212666
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=212666&view=rev
>>> Log:
>>> [Driver] Expose getARMCPUForMArch() function in the Driver API; NFC.
>>>
>>> Modified:
>>>    cfe/trunk/include/clang/Driver/Util.h
>>>    cfe/trunk/lib/Driver/Tools.cpp
>>>
>>> Modified: cfe/trunk/include/clang/Driver/Util.h
>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Util.h?rev=212666&r1=212665&r2=212666&view=diff
>>> ==============================================================================
>>> --- cfe/trunk/include/clang/Driver/Util.h (original)
>>> +++ cfe/trunk/include/clang/Driver/Util.h Wed Jul  9 20:03:37 2014
>>> @@ -13,6 +13,10 @@
>>> #include "clang/Basic/LLVM.h"
>>> #include "llvm/ADT/DenseMap.h"
>>>
>>> +namespace llvm {
>>> +  class Triple;
>>> +}
>>> +
>>> namespace clang {
>>> class DiagnosticsEngine;
>>>
>>> @@ -26,6 +30,9 @@ namespace driver {
>>>   /// ActionList - Type used for lists of actions.
>>>   typedef SmallVector<Action*, 3> ActionList;
>>>
>>> +/// Get the (LLVM) name of the minimum ARM CPU for the arch we are targeting.
>>> +const char* getARMCPUForMArch(StringRef MArch, const llvm::Triple &Triple);
>>> +
>>> } // end namespace driver
>>> } // end namespace clang
>>>
>>>
>>> Modified: cfe/trunk/lib/Driver/Tools.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=212666&r1=212665&r2=212666&view=diff
>>> ==============================================================================
>>> --- cfe/trunk/lib/Driver/Tools.cpp (original)
>>> +++ cfe/trunk/lib/Driver/Tools.cpp Wed Jul  9 20:03:37 2014
>>> @@ -5025,9 +5025,6 @@ void hexagon::Link::ConstructJob(Compila
>>> }
>>> // Hexagon tools end.
>>>
>>> -/// getARMCPUForMArch - Get the (LLVM) name of the minimum ARM CPU for the arch we are targeting
>>> -//
>>> -// FIXME: tblgen this.
>>> const char *arm::getARMCPUForMArch(const ArgList &Args,
>>>                                    const llvm::Triple &Triple) {
>>>   StringRef MArch;
>>> @@ -5049,6 +5046,14 @@ const char *arm::getARMCPUForMArch(const
>>>     }
>>>   }
>>>
>>> +  return driver::getARMCPUForMArch(MArch, Triple);
>>> +}
>>> +
>>> +/// Get the (LLVM) name of the minimum ARM CPU for the arch we are targeting.
>>> +//
>>> +// FIXME: tblgen this.
>>> +const char *driver::getARMCPUForMArch(StringRef MArch,
>>> +                                      const llvm::Triple &Triple) {
>>>   switch (Triple.getOS()) {
>>>   case llvm::Triple::NetBSD:
>>>     if (MArch == "armv6")
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>