[PATCH] clang-cl: Store the linker options for the ASAN runtime libraries in the obj files as opposed to pass it to the linker on the command line

[Reid Kleckner]

On Wed, Jul 9, 2014 at 2:39 PM, Ehsan Akhgari <ehsan.akhgari at gmail.com>
wrote:

> On Wed, Jul 9, 2014 at 5:18 PM, Reid Kleckner <rnk at google.com> wrote:
>
>> Generally we want to be careful about embedding full paths into the
>> binary.  While nobody is doing distributed builds today, in the future we
>> want to support that.
>>
>> What do you think of embedding just the basename into .drectve, and
>> adding clang's resource dir to the LIB environment variable in the build
>> system?  That's a far less invasive change than making clang do the link
>> step instead of link.exe, and should solve the problem.
>>
>
> That sounds fine for my needs.  But it will break the simple case where
> someone does:
>
> clang-cl -c -fsanitize=address foo.cpp
> link foo.obj
>

That's OK, it doesn't work today.  I think we can also solve this for many
first time users in our VS integration by always adding our library
resource directory to LIB.  Anything else we need to link in like the
profiler library will come from there.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140709/7a891e69/attachment.html>