[PATCH] Avoid definining more GCC specific predefined macros in clang-cl
rnk at google.com
Wed Jul 9 13:33:50 PDT 2014
On Wed, Jul 9, 2014 at 9:06 AM, Alp Toker <alp at nuanti.com> wrote:
> On 09/07/2014 18:48, David Majnemer wrote:
>> I don't think that MSVC compat is the right predicate here, this has more
>> to do with targeting the msvc environment.
> We're planning go over these soon and switch them to a more appropriate
> flag like GCCCompat, which will generally be set to !MSVCCompat -- so
> Ehsan's approach is fine for now and easy to move to the new scheme when
I agree, I think we should be able to separate which compiler we're
pretending to be from the ABI we're targeting.
So, checking MSVCCompat for now looks good to me. It's consistent with our
other checks in this file and we can switch them all en masse in the future.
I always want to define some target things like __LP64__, __SSE3__, and
__x86_64__, though, since they make our *mmintrin.h headers work.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits