r212591 - clang-format: Revamp function declaration/definition indentation.

Tobias Grosser tobias at grosser.es
Wed Jul 9 03:15:58 PDT 2014

On 09/07/2014 11:33, Daniel Jasper wrote:
> On Wed, Jul 9, 2014 at 11:08 AM, Tobias Grosser <tobias at grosser.es> wrote:
> a) That is not a lot (<1% of the codebase).

It affects the formatting of almost all cl::opt uses.

>> Sure, would it be OK to revert this change meanwhile to get the build bot
>> clean again.
> No. I think it is highly likely, we are going to stick with this change.

Daniel, I believe it is common habit that if someone requests a revert, 
this revert is performed and the discussion takes place.

> Moreover, I think the issue here is that we have a buildbot enforcing a
> format based on clang-format's HEAD version.

I believe it is good to understand how clang-format changes over time. 
Most changes are insignificant for the existing code so I adjust Polly 
immediately. The same holds for style changes that have been agreed on 
in the community.


More information about the cfe-commits mailing list