r212591 - clang-format: Revamp function declaration/definition indentation.

[Tobias Grosser]

On 09/07/2014 09:50, Daniel Jasper wrote:
> Author: djasper
> Date: Wed Jul  9 02:50:33 2014
> New Revision: 212591
>
> URL: http://llvm.org/viewvc/llvm-project?rev=212591&view=rev
> Log:
> clang-format: Revamp function declaration/definition indentation.
>
> Key changes:
> - Correctly (well ...) distinguish function declarations and variable
>    declarations with ()-initialization.
> - Don't indent when breaking function declarations/definitions after the
>    return type.
> - Indent variable declarations and typedefs when breaking after the
>    type.
>
> This fixes llvm.org/PR17999.

I think this commit changed the formatting of global command line 
declarations in LLVM:

static cl::opt<bool>
DetectScopsWithoutLoops("polly-detect-scops")

became:

static cl::opt<bool>
     DetectScopsWithoutLoops("polly-detect-scops")

and

static cl::opt<std::string>
OnlyFunction("polly-only-func")..

became


static cl::opt<std::string> OnlyFunction(
     "polly-only-func")

I personally was very happy with the previous formatting. Was this 
change intended?

As this introduces a large difference compared to clang-format-3.4, I 
would prefer to keep the existing style.

Tobias