[PATCH] Adding 4 ASTMatchers: typedefDecl, isInMainFile, isInSystemFile, isInFileMatchingName

Alexander Kornienko alexfh at google.com
Tue Jul 8 09:35:53 PDT 2014

On Sun, Jun 29, 2014 at 10:46 PM, Hendrik v. P. <raise.rescue at gmail.com>

> Hi,
> last week, I uploaded a patch for being reviewed on phabricator (
> http://reviews.llvm.org/D4283). I'm just curios if I did it right and
> someone will ever take notice of it, or if I made some mistakes that will
> prevent you to review it and I should change in future.

Well, you should've added cfe-commits to cc: and ideally someone from the
maintainers of the relevant library to reviewers:. I'm cc-ing people who
can review your patch.

> Thank you in advance,
> Hendrik
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Alexander Kornienko | Software Engineer | alexfh at google.com | Google
Germany, Munich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140708/1996f9af/attachment.html>

More information about the cfe-commits mailing list