r212060 - Consider module depedencies when checking a preamble in libclang

Ben Langmuir blangmuir at apple.com
Tue Jul 8 08:03:48 PDT 2014

> On Jul 7, 2014, at 11:10 AM, Ulrich Weigand <Ulrich.Weigand at de.ibm.com> wrote:
> Ben Langmuir <blangmuir at apple.com> wrote on 07.07.2014 19:03:33:
>> I’ll fix the test to specify a unique module cache path.
> Thanks, that will certainly fix the test case problem!
>> In general, we use llvm::sys::path::system_temp_dir to create
>> the default module cache location.  On Darwin, we use
>> DARWIN_USER_CACHE_DIR, which is user-specific so this isn’t an
>> issue.  On Linux, we seem to honour the environment variable TMPDIR,
>> before falling back to /var/tmp. I don’t know if this is correct for
>> Linux; perhaps you know of a better way?
> I'm not really an expert here ...
> One option might be to include the user name in the temp directory
> name; I see for example
>   /var/tmp/kdecache-uweigand
> (owned by my uweigand user ID) on my desktop machine …

That seems fine to me, FWIW.  Do you feel like putting together a patch? Or I can do it when I have some time.


> Bye,
> Ulrich

More information about the cfe-commits mailing list