[PATCH] [libcxxabi] Add lit configs for libcxxabi tests.

Dan Albert danalbert at google.com
Mon Jul 7 22:20:25 PDT 2014

Comment at: CMakeLists.txt:110
@@ +109,3 @@
+  else()
+  endif()
Saleem Abdulrasool wrote:
> Dan Albert wrote:
> > Saleem Abdulrasool wrote:
> > > I think that you should use a separate variable (LIBCXX_INCLUDE_DIR perhaps?) that is set to ${CMAKE_CURRENT_BINARY_DIR}/include rather than relying on LLVM's variable.
> > > 
> > > I realize that this is a standalone build, and therefore LLVM_INCLUDE_DIR *should* point to the same location, but it makes it something that you need to reason out (at least, I had to think about it for a moment).
> > I don't understand. ${CMAKE_CURRENT_BINARY_DIR}/include won't contain the libcxx headers...
> AIUI, thats what it will be set to.  It does actually get the headers copied there (at least, it did in my local tree).
Hmm. They aren't for mine. Not for a standalone build, anyway. I'm running exactly the command from the docs.


More information about the cfe-commits mailing list