r212393 - Fix the MicrosoftExtensions.c target

[Ehsan Akhgari]

On Sun, Jul 6, 2014 at 10:03 AM, Aaron Ballman <aaron at aaronballman.com>
wrote:

> On Sun, Jul 6, 2014 at 1:58 AM, Ehsan Akhgari <ehsan.akhgari at gmail.com>
> wrote:
> > Author: ehsan
> > Date: Sun Jul  6 00:58:55 2014
> > New Revision: 212393
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=212393&view=rev
> > Log:
> > Fix the MicrosoftExtensions.c target
> >
> > Modified:
> >     cfe/trunk/test/Parser/MicrosoftExtensions.c
> >
> > Modified: cfe/trunk/test/Parser/MicrosoftExtensions.c
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Parser/MicrosoftExtensions.c?rev=212393&r1=212392&r2=212393&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/test/Parser/MicrosoftExtensions.c (original)
> > +++ cfe/trunk/test/Parser/MicrosoftExtensions.c Sun Jul  6 00:58:55 2014
> > @@ -1,3 +1,4 @@
> > +// REQUIRES: x86-registered-target
> >  // RUN: %clang_cc1 -triple i386-mingw32 -fsyntax-only -verify
> -fms-extensions  -Wno-missing-declarations -x objective-c++ %s
>
> I don't believe this is the correct fix for this problem. Please split
> the inline assembly out into its own test instead
> (MicrosoftExtensions-x86.c). That way, the remaining parts of this
> test will run on all of the bots. (This is a very general test file
> for MS extensions, so reducing test coverage is a bad thing).
>

Done: http://reviews.llvm.org/D4401

Sorry about this!

--
Ehsan
<http://ehsanakhgari.org/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140706/aac97dfe/attachment.html>