r212395 - libclang: make darwin pthread hacks conditional on LLVM_ENABLE_THREADS
Alp Toker
alp at nuanti.com
Sat Jul 5 23:24:00 PDT 2014
Author: alp
Date: Sun Jul 6 01:24:00 2014
New Revision: 212395
URL: http://llvm.org/viewvc/llvm-project?rev=212395&view=rev
Log:
libclang: make darwin pthread hacks conditional on LLVM_ENABLE_THREADS
Although these aren't strictly related to LLVM's core threading, it's
reasonable to avoid pthread usage in clang when building with
LLVM_ENABLE_THREADS disabled.
Modified:
cfe/trunk/tools/libclang/CIndex.cpp
Modified: cfe/trunk/tools/libclang/CIndex.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndex.cpp?rev=212395&r1=212394&r2=212395&view=diff
==============================================================================
--- cfe/trunk/tools/libclang/CIndex.cpp (original)
+++ cfe/trunk/tools/libclang/CIndex.cpp Sun Jul 6 01:24:00 2014
@@ -53,7 +53,11 @@
#include "llvm/Support/Timer.h"
#include "llvm/Support/raw_ostream.h"
-#ifdef __APPLE__
+#if LLVM_ENABLE_THREADS != 0 && defined(__APPLE__)
+#define USE_DARWIN_THREADS
+#endif
+
+#ifdef USE_DARWIN_THREADS
#include <pthread.h>
#endif
@@ -6799,8 +6803,7 @@ void clang::setThreadBackgroundPriority(
if (getenv("LIBCLANG_BGPRIO_DISABLE"))
return;
- // FIXME: Move to llvm/Support and make it cross-platform.
-#ifdef __APPLE__
+#ifdef USE_DARWIN_THREADS
setpriority(PRIO_DARWIN_THREAD, 0, PRIO_DARWIN_BG);
#endif
}
@@ -7014,8 +7017,8 @@ cxindex::Logger::~Logger() {
raw_ostream &OS = llvm::errs();
OS << "[libclang:" << Name << ':';
- // FIXME: Portability.
-#ifdef __APPLE__
+#ifdef USE_DARWIN_THREADS
+ // TODO: Portability.
mach_port_t tid = pthread_mach_thread_np(pthread_self());
OS << tid << ':';
#endif
More information about the cfe-commits
mailing list