[clang-tools-extra] r212271 - clang-tidy: Instantiate llvm::Registry<clang::tidy::ClangTidyModule>.

[NAKAMURA Takumi]

2014-07-04 0:50 GMT+09:00 Alexander Kornienko <alexfh at google.com>:
> Can you explain why this change is needed?

Excuse me for my non-descriptive commit.
It is required for -DBUILD_SHARED_LIBS=ON on Win32 DLL.

Win32 DLL is incapable to merge sections among DLLs.
Then static members in llvm::Registry should be instantiated in the
registrar (clangTidy.dll).


> On Thu, Jul 3, 2014 at 3:12 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
>>
>> Author: chapuni
>> Date: Thu Jul  3 09:12:47 2014
>> New Revision: 212271
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=212271&view=rev
>> Log:
>> clang-tidy: Instantiate llvm::Registry<clang::tidy::ClangTidyModule>.
>>
>> Modified:
>>     clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
>>     clang-tools-extra/trunk/clang-tidy/ClangTidyModuleRegistry.h
>>
>> Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp?rev=212271&r1=212270&r2=212271&view=diff
>>
>> ==============================================================================
>> --- clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp (original)
>> +++ clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp Thu Jul  3 09:12:47
>> 2014
>> @@ -46,6 +46,8 @@ using namespace clang::driver;
>>  using namespace clang::tooling;
>>  using namespace llvm;
>>
>> +template class llvm::Registry<clang::tidy::ClangTidyModule>;
>> +
>>  namespace clang {
>>  namespace tidy {
>>
>>
>> Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyModuleRegistry.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/ClangTidyModuleRegistry.h?rev=212271&r1=212270&r2=212271&view=diff
>>
>> ==============================================================================
>> --- clang-tools-extra/trunk/clang-tidy/ClangTidyModuleRegistry.h
>> (original)
>> +++ clang-tools-extra/trunk/clang-tidy/ClangTidyModuleRegistry.h Thu Jul
>> 3 09:12:47 2014
>> @@ -13,6 +13,8 @@
>>  #include "ClangTidyModule.h"
>>  #include "llvm/Support/Registry.h"
>>
>> +extern template class llvm::Registry<clang::tidy::ClangTidyModule>;
>> +
>>  namespace clang {
>>  namespace tidy {
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>