r207829 - CodeGen: rename __builtin_arm_sevl to __sevl

[Yi Kong]

Thanks for working on this. But should the intrinsics have
__builtin_arm_ prefix instead of __builtin_?

Cheers,
Yi

On 2 July 2014 18:58, Saleem Abdulrasool <compnerd at compnerd.org> wrote:
> On Mon, Jun 30, 2014 at 3:21 PM, Saleem Abdulrasool <abdulras at fb.com> wrote:
>>
>>
>> On Jun 30, 2014, at 11:06 AM, Reid Kleckner <rnk at google.com> wrote:
>>
>> > This should be doable by extending BuiltinsARM.def to use LANGBUILTIN
>> > and adding LANGBUILTIN(__sevl, ..., ALL_MS_LANGUAGES).
>>
>> Sounds good to me, Ill take a look and see if I can actually get this
>> approach to work.
>
>
> SVN r212196 should change the names to the __builtin_ prefixed versions.
> MSVC compatibility enables the unprefixed names.
>
> Ill try to do a follow up change where I add the aliases into arm_acle.h
> along with a test to ensure that it can be included while retaining MSVC
> compatibility.
>
>>
>> >
>> > On Mon, Jun 30, 2014 at 2:10 AM, Renato Golin <renato.golin at linaro.org>
>> > wrote:
>> > On 30 June 2014 10:00, Yi Kong <kongy.dev at gmail.com> wrote:
>> > > I see MSVC has a long list of ARM Intrinsics, all named differently
>> > > from Clang. It's not feasible to rename Clang's intrinsics to MSVC's.
>> > > I think you should make __selv(and others) be MSVC specific and active
>> > > only in -fms-extensions.
>> >
>> > I agree. OS specific stuff should be a localization issue, while ABI
>> > stuff should be in the generic code.
>> >
>> > Yi, can you get the MSVC intrinsics into a class of their own? The
>> > builtins ARM test should differentiate between Win and ABI versions,
>> > as well.
>> >
>> > cheers,
>> > --renato
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at cs.uiuc.edu
>> >
>> > https://urldefense.proofpoint.com/v1/url?u=http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=CchYc4lrV44%2BZqxZADw0BQ%3D%3D%0A&m=KVXydYXSqQatEoH80QyKFZwkyzZQVtPRzI2G0IZeBAI%3D%0A&s=4cc4ed16ac775e3b83ebaa285814697aeefd5d209ac227e1ab550457c673248f
>>
>> --
>> Saleem Abdulrasool
>> abdulras (at) fb (dot) com
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>