[PATCH] [libcxxabi] Add a cmake build system.

Dan Albert danalbert at google.com
Tue Jul 1 17:23:33 PDT 2014


================
Comment at: src/CMakeLists.txt:57
@@ +56,3 @@
+
+string(REPLACE ";" " " link_flags "${link_flags}")
+
----------------
Alexey Samsonov wrote:
> Dan Albert wrote:
> > Alexey Samsonov wrote:
> > > Do you need to do the same for compile_flags?
> > I actually have no idea why this is here. I copied most of this from the libc++ cmake files and tuned as necessary.
> > 
> > It's done for the compile flags in the main CMakeLists.txt (applied to LIBCXXABI_CXX_*_FLAGS, as these can contain parts specified from the command line using ; as a delimiter). I don't see anything about the ldflags that would need replacement though... I'll remove it.
> Well, link_flags is a CMake list type, its elements will be semicolon-separated if you add them with list(APPEND link_flags foo).
Ah, didn't know that (not very familiar with cmake). So is it necessary, or is cmake smart enough to do the replacement itself?

http://reviews.llvm.org/D4359






More information about the cfe-commits mailing list