r212091 - Temporarily disable the indirect-goto.c test.

[Bob Wilson]

In fact, Gerolf has already reenabled the test in r212092, with some changes. The commit message didn’t go out right away because it got moderated.

We’re still looking into fixing the issues that required tweaking the test.

> On Jul 1, 2014, at 8:39 AM, Bob Wilson <bob.wilson at apple.com> wrote:
> 
> The failure was expected and we had discussed whether to go ahead with the change anyway during the review of the patch in r212077. That changes fixes a correctness issue at the temporary expense of a fairly minor optimization. It’s the right thing to do, and no one objected. Gerolf and I are confident we can get the optimization back, but we shouldn’t rush those changes since some of them deserve careful benchmarking to make sure we don’t regress anything else.
> 
>> On Jun 30, 2014, at 10:23 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> 
>> On Mon, Jun 30, 2014 at 9:56 PM, Bob Wilson <bob.wilson at apple.com> wrote:
>>> Author: bwilson
>>> Date: Mon Jun 30 23:56:06 2014
>>> New Revision: 212091
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=212091&view=rev
>>> Log:
>>> Temporarily disable the indirect-goto.c test.
>>> 
>>> llvm r212077 causes this test to fail. We need to reorder some passes and
>>> possibly make other changes to reenable the optimization being tested here.
>> 
>> Seems like it might be more suitable to revert the regressing patch
>> then - rather than leaving the tree missing the optimization.
>> 
>> Just a thought (we've had a few cases of people checking in code then
>> reverting/disabling failing tests - doesn't seem ideal)
>> 
>>> 
>>> Modified:
>>>   cfe/trunk/test/CodeGen/indirect-goto.c
>>> 
>>> Modified: cfe/trunk/test/CodeGen/indirect-goto.c
>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/indirect-goto.c?rev=212091&r1=212090&r2=212091&view=diff
>>> ==============================================================================
>>> --- cfe/trunk/test/CodeGen/indirect-goto.c (original)
>>> +++ cfe/trunk/test/CodeGen/indirect-goto.c Mon Jun 30 23:56:06 2014
>>> @@ -1,4 +1,5 @@
>>> -// RUN: %clang_cc1 -triple i386-unknown-unknown -O3 -emit-llvm -o - %s | grep "ret i32 2520"
>>> +// RUN: %clang_cc1 -triple i386-unknown-unknown -O3 -emit-llvm -o - %s
>>> +// DISABLED: %clang_cc1 -triple i386-unknown-unknown -O3 -emit-llvm -o - %s | grep "ret i32 2520"
>>> 
>>> static int foo(unsigned i) {
>>>  void *addrs[] = { &&L1, &&L2, &&L3, &&L4, &&L5 };
>>> 
>>> 
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>