[PATCH] Do not define __STRICT_ANSI__ in clang-cl
Alp Toker
alp at nuanti.com
Mon Jun 30 13:52:13 PDT 2014
On 30/06/2014 23:45, Manuel Klimek wrote:
> On Mon, Jun 30, 2014 at 9:31 PM, Alp Toker <alp at nuanti.com
> <mailto:alp at nuanti.com>> wrote:
>
> LGTM
>
> BTW Ehsan, your mail looks like a reply to itself and doesn't
> reference my Message-Id for threading, nor is the To or CC
> addressed to me in any way so I had no way of knowing you replied
> other than spotting it on the list archive.
>
> Manuel, could you update the website-based review guideline to
> indicate that submitters should include on-list reviewers in their
> replies?
>
>
> The original email and the reply have the same Thread-Index - your
> email doesn't have one (I know it's non-standard, but last time I
> checked I didn't find a widely supported standard) - Message-ID is
> afaik a unique identifier (http://en.wikipedia.org/wiki/Message-ID).
> What am I missing?
Any one of a CC, To or an In-Reply-To would let web-based responses show
up in a standard email client's inbox or threading.
Right now any responses to comments I make are getting lost in the
noise, and I have to go through the list to see if anyone replied.
Surely people who review / reply should get added to the CC list
automatically?
Alp.
>
> Cheers,
> /Manuel
>
>
>
> Alp.
>
>
>
>
> On 30/06/2014 22:55, Ehsan Akhgari wrote:
>
> Moved the test.
>
> http://reviews.llvm.org/D4350
>
> Files:
> lib/Frontend/InitPreprocessor.cpp
> test/Preprocessor/predefined-macros.c
>
> Index: lib/Frontend/InitPreprocessor.cpp
> ===================================================================
> --- lib/Frontend/InitPreprocessor.cpp
> +++ lib/Frontend/InitPreprocessor.cpp
> @@ -433,7 +433,7 @@
> // Initialize language-specific preprocessor defines.
> // Standard conforming mode?
> - if (!LangOpts.GNUMode)
> + if (!LangOpts.GNUMode && !LangOpts.MSVCCompat)
> Builder.defineMacro("__STRICT_ANSI__");
> if (LangOpts.CPlusPlus11)
> Index: test/Preprocessor/predefined-macros.c
> ===================================================================
> --- test/Preprocessor/predefined-macros.c
> +++ test/Preprocessor/predefined-macros.c
> @@ -9,6 +9,7 @@
> // CHECK-MS: #define _M_IX86_FP
> // CHECK-MS: #define _WIN32 1
> // CHECK-MS-NOT: #define __GNUC__
> +// CHECK-MS-NOT: #define __STRICT_ANSI__
> //
> // RUN: %clang_cc1 %s -E -dM -ffast-math -o - \
> // RUN: | FileCheck %s --check-prefix=CHECK-FAST-MATH
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
> --
> http://www.nuanti.com
> the browser experts
>
>
--
http://www.nuanti.com
the browser experts
More information about the cfe-commits
mailing list